Toggle button #64
Merged
Toggle button #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I haven't edited Toggle Button yet. Is it closed or do you want me to edit it? |
|
Erik, the pull request is not closed and Toggle Button documentation should be edited. Is there something that stops you? |
|
It shows as closed 17 days ago, by you. |
danail-vasilev
force-pushed
the
ToggleButton
branch
5 times, most recently
from
e56b05f to
ef8852f
Compare
danail-vasilev
force-pushed
the
ToggleButton
branch
from
d8a2c96 to
71b30e3
Compare
Minor editing changes.
Editing changes.
Minor copy editing changes.
copy editing changes.
copy editing changes
minor editing changes
Minor edits
Minor copy editing changes
Minor editing changes
minor copy changes
Please review the inline comment I added, make the change I propose if correct, and then remove my inline comment.
Copy editing changes. At first while editing this I had comments in the article when I started to see some properties repeated in different sections. You might help the customer if you state that some properties can be set for the button, for a toggle state, for an icon or for image-specific features. I was confused until I figured out why they were repeated.
I made some minor edits that you will agree with, but I wonder if this headline "Hovered, Active and Disabled States" is a little misleading. The properties in the article are PressedUrl, HoveredUrl and DisabledUrl and I don't think "pressed" and "active" are the same thing. In example 2 you also discuss an image for the button in normal state. Why isn't "normal" part of the same headline? Is there also a property for normal that isn't discussed in the article? Also, your slug for this article doesn't match the properties discussed in the article, so that's worse for search.
Please see the comments inline. Also, in the second way to configure the rendering mode of RadToggleButton using a global setting, the example never mentions RadToggleButton. It is implied that RadToggleButton is a PushButton but I don't remember reading that anywhere so I suggest you specifically say that here.
See my long comment.
Please see my comment about elastic design for this control. I think you need a better explanation about fluid vs responsive at the beginning of this article. I think to many of your customers, your definition of fluid is also what they think of when they think about responsive design, so I don't think you explain fluid design in enough detail.
I had an email exchange with Marin about Elastic vs Fluid vs Responsive on 21 December, and he said to add a comment that this help article (and all help articles that touch on this topic) have paragraphs that describe what fluid/elastic design is. Please add that. Here is the example he gave me about elastic design: http://docs.telerik.com/devtools/aspnet-ajax/controls/tilelist/mobile-support/elastic-capabilities. Here is the example he gave me about fluid design: http://docs.telerik.com/devtools/aspnet-ajax/controls/rotator/mobile-support/fluid-capabilities
danail-vasilev
force-pushed
the
ToggleButton
branch
from
c148b43 to
f72832a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues from Toggle button.