-
Notifications
You must be signed in to change notification settings - Fork 80
Documentation - Linear Gauge #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a lot of comments, but nothing is really major, just minor tweaks that can take the whole docs to a new level. I like the structure and how you can find the main elements of the component at the root level of the docs, and so many details and examples for each.
While I'd like to see those comments acted on, I am approving this PR.
EDIT: you could also mention the gauges (may be as a single bullet "Gauges") in the KBD nav article just like we do for the chart so it is clear they can't have kbd navigation.
_config.yml
Outdated
| "Radar Column Charts": "chart-types-radarcolumn" | ||
| "Radar Line Charts": "chart-types-radarline" | ||
| "Stock Chart": "stockchart-overview" | ||
| "Gauge - Linear": "linear-gauge-overview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider calling these "Linear Gauge", "Circular Gauge" and so on here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
New Component Checklist (delete for other types of PRs)
- Overview article
- Data binding article - applicable if data can be provided to the component. My be one article or a folder with several articles (examples - DropDownList and TreeView)
- Feature/component specific articles - those articles explain the component specific features, which do not suit in any of the before-mentioned articles. Examples of such articles are the Navigator for the Stock Chart, the Indeterminate state for the CheckBox and others.
- Selection article - applicable if the component exposes items selection. May be a folder.
[ ] - Single item selection
[ ] - Multiple item selection
- Templates - applicable if additional customization is allowed with Templates. Usually a folder, see the grid
- Events article - applicable if the component expose events.
Examples of such events could be:
Update Input Validation, Globalization, Keyboard Navigation, Accessibility Compliance articles as applicable.
Link from the Overview components list