docs: environmental configuration #3947
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📖 Docs PR preview links
|
| title: Ruby SDK developer guide | ||
| sidebar_label: Ruby SDK | ||
| description: Use the Temporal Ruby SDK to develop Temporal Applications, connect to the Temporal Service, test Workflows and Activities, handle failures, send messages, and more. | ||
| description: |
There was a problem hiding this comment.
maybe revert the index pages for the SDKs. unless it's only adding a bullet point for the environ config part under Temporal Client?
There was a problem hiding this comment.
ah, the change in the index pages are related to anchors. The anchors in the Temporal Client page has changed so I updated these to avoid broken anchors
|
|
||
| // Test the connection by checking the service | ||
| var sysInfo = await client.Connection.WorkflowService.GetSystemInfoAsync(new()); | ||
| Console.WriteLine("✅ Successfully verified connection to Temporal server!\n{0}", sysInfo); |
There was a problem hiding this comment.
We could prob remove the emojis here and in the rest of the samples.
There was a problem hiding this comment.
I guess it might have been was in the original doc but I feel like they make me suspicious of the code lol
There was a problem hiding this comment.
These are in the sample code though. I was going to use Snipsync to fetch it directly but I don't think there is time to put the snippets in, but they'd have these emojis too.
Does it make you suspicious because you suspect AI?
There was a problem hiding this comment.
Yes lol none of my comments are blocking though. We can just do a next iteration off of whatever is published.
|
|
||
| The environment variables are defined in the [UI server configuration template file](https://github.com/temporalio/ui-server/blob/main/docker/config-template.yaml) and described in more detail below. | ||
| The environment variables are defined in the | ||
| [UI server configuration template file](https://github.com/temporalio/ui-server/blob/main/docker/config-template.yaml) |
There was a problem hiding this comment.
It says page not found for this. But this looks like it's also not found on the live site.
There was a problem hiding this comment.
Hmm, this one was not part of my PR. It showed up here I think because of prettier. But i think i found the right link and replaced it
What does this PR do?
Notes to reviewers