-
Notifications
You must be signed in to change notification settings - Fork 279
Python: Add sandbox import notification policy documentation #3973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📖 Docs PR preview links
|
| ..., | ||
| workflow_runner=SandboxedWorkflowRunner( | ||
| restrictions=SandboxRestrictions.default.with_import_notification_policy( | ||
| workflow.SandboxImportNotificationPolicy.WARN_ON_UNINTENTIONAL_PASSTHROUGH | workflow.SandboxImportNotificationPolicy.WARN_ON_UNINTENTIONAL_PASSTHROUGH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears twice or maybe it's intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't intentional! Thanks for catching. I've updated the example to use the two warning types instead of the same one twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok perfect. Taking a look at this today.
Co-authored-by: Jwahir Sundai <jwahir.sundai@temporal.io>
What does this PR do?
Adds documentation about the new Python sandbox setting
import_notification_policythat was added in temporalio/sdk-python#1187.Notes to reviewers