Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/develop/dotnet/benign-exceptions.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,4 @@ public class MyActivities
}
```

Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
5 changes: 1 addition & 4 deletions docs/develop/go/temporal-client.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,7 @@ code. This is convenient for local development and testing. You can also load a
variables or a configuration file, and then override specific options in code.

{/* SNIPSTART samples-apps-go-yourapp-gateway {"selectedLines": ["1-23", "32"]} */}

[sample-apps/go/yourapp/gateway/main.go](https://github.com/temporalio/documentation/blob/main/sample-apps/go/yourapp/gateway/main.go)

```go
package main

Expand All @@ -233,10 +231,9 @@ func main() {
log.Fatalln("Unable to create Temporal Client", err)
}
defer temporalClient.Close()
// ...
// ...
}
```

{/* SNIPEND */}

</TabItem>
Expand Down
2 changes: 1 addition & 1 deletion docs/develop/java/benign-exceptions.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@ public class MyActivitiesImpl implements MyActivities {
}
```

Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
2 changes: 1 addition & 1 deletion docs/develop/python/benign-exceptions.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,4 @@ async def my_activity() -> str:
)
```

Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
2 changes: 1 addition & 1 deletion docs/develop/ruby/benign-exceptions.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@ class MyActivity < Temporalio::Activity::Definition
end
```

Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
2 changes: 1 addition & 1 deletion docs/develop/typescript/benign-exceptions.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ export async function myActivity(): Promise<string> {
}
```

Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
Use benign exceptions for Activity errors that occur regularly as part of normal operations, such as polling an external service that isn't ready yet, or handling expected transient failures that will be retried.
8 changes: 4 additions & 4 deletions docs/develop/typescript/cancellation.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ To simplify checking for cancellation, use the
<!--SNIPSTART typescript-cancel-a-timer-from-workflow-->
[packages/test/src/workflows/cancel-timer-immediately.ts](https://github.com/temporalio/sdk-typescript/blob/main/packages/test/src/workflows/cancel-timer-immediately.ts)
```ts
import { CancellationScope, CancelledFailure, sleep } from '@temporalio/workflow';
import { CancelledFailure, CancellationScope, sleep } from '@temporalio/workflow';

export async function cancelTimer(): Promise<void> {
// Timers and Activities are automatically cancelled when their containing scope is cancelled.
Expand All @@ -95,7 +95,7 @@ Alternatively, the preceding can be written as the following.
<!--SNIPSTART typescript-cancel-a-timer-from-workflow-alternative-impl-->
[packages/test/src/workflows/cancel-timer-immediately-alternative-impl.ts](https://github.com/temporalio/sdk-typescript/blob/main/packages/test/src/workflows/cancel-timer-immediately-alternative-impl.ts)
```ts
import { CancellationScope, CancelledFailure, sleep } from '@temporalio/workflow';
import { CancelledFailure, CancellationScope, sleep } from '@temporalio/workflow';

export async function cancelTimerAltImpl(): Promise<void> {
try {
Expand Down Expand Up @@ -123,7 +123,7 @@ The following code shows how to handle Workflow cancellation by an external clie
<!--SNIPSTART typescript-handle-external-workflow-cancellation-while-activity-running-->
[packages/test/src/workflows/handle-external-workflow-cancellation-while-activity-running.ts](https://github.com/temporalio/sdk-typescript/blob/main/packages/test/src/workflows/handle-external-workflow-cancellation-while-activity-running.ts)
```ts
import { CancellationScope, isCancellation, proxyActivities } from '@temporalio/workflow';
import { CancellationScope, proxyActivities, isCancellation } from '@temporalio/workflow';
import type * as activities from '../activities';

const { httpPostJSON, cleanup } = proxyActivities<typeof activities>({
Expand Down Expand Up @@ -248,7 +248,7 @@ You can achieve complex flows by nesting cancellation scopes.
<!--SNIPSTART typescript-nested-cancellation-scopes-->
[packages/test/src/workflows/nested-cancellation.ts](https://github.com/temporalio/sdk-typescript/blob/main/packages/test/src/workflows/nested-cancellation.ts)
```ts
import { CancellationScope, isCancellation, proxyActivities } from '@temporalio/workflow';
import { CancellationScope, proxyActivities, isCancellation } from '@temporalio/workflow';

import type * as activities from '../activities';

Expand Down