Gate worker heartbeating behind namespace capabilities #1046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR needs a server patch release that includes sending this information in namespace capabilities.
What was changed
Call
DescribeNamespaceand gate worker heartbeating from the worker_heartbeat CapabilityWhy?
So older servers without this support don't get pinged and emit server error logs for unimplemented
Checklist
Closes
How was this tested:
Note
Before sending worker heartbeats, check
DescribeNamespaceforcapabilities.worker_heartbeats; if unsupported or on error, warn and shut down the worker; tests updated accordingly.describe_namespaceand requiringnamespace_info.capabilities.worker_heartbeats == true.shutdownworker.record_worker_heartbeatUnimplementederror:shutdownworker.describe_namespacewithworker_heartbeats: true.Written by Cursor Bugbot for commit 70b9ad0. This will update automatically on new commits. Configure here.