Skip to content

Rename event_loop to avoid confusion with lang SDK #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Rename event_loop to avoid confusion with lang SDK #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60e1f17
Rename event_loop to avoid confusion with lang SDK
Sushisource Feb 18, 2021
8f8bccc
Extra comma.
Sushisource Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name = "temporal-sdk-core"
version = "0.1.0"
authors = ["Spencer Judge <spencer@temporal.io>", "Vitaly Arbuzov <vitaly@temporal.io>"]
edition = "2018"
license = "MIT"
license-file = "LICENSE.txt"

[lib]
Expand Down
1 change: 0 additions & 1 deletion fsm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name = "rustfsm"
version = "0.1.0"
authors = ["Spencer Judge <sjudge@hey.com>"]
edition = "2018"
license = "MIT"
license-file = "LICENSE.txt"

[dependencies]
Expand Down
1 change: 0 additions & 1 deletion fsm/state_machine_procmacro/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name = "state_machine_procmacro"
version = "0.1.0"
authors = ["Spencer Judge <sjudge@hey.com>"]
edition = "2018"
license = "MIT"
license-file = "LICENSE.txt"

[lib]
Expand Down
1 change: 0 additions & 1 deletion fsm/state_machine_trait/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name = "state_machine_trait"
version = "0.1.0"
authors = ["Spencer Judge <sjudge@hey.com>"]
edition = "2018"
license = "MIT"
license-file = "LICENSE.txt"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ impl<WP: ServerGatewayApis> CoreSDK<WP> {
.collect::<Result<Vec<_>>>()?;
self.access_machine(run_id, |mgr| {
mgr.command_sink.send(cmds)?;
mgr.machines.event_loop();
mgr.machines.iterate_machines();
Ok(())
})?;
Ok(())
Expand Down
8 changes: 4 additions & 4 deletions src/machines/workflow_machines.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ impl WorkflowMachines {

self.current_started_event_id = task_started_event_id;
self.set_current_time(time);
self.event_loop();
self.iterate_machines();
}

/// A command event is an event which is generated from a command emitted by a past decision.
Expand Down Expand Up @@ -379,9 +379,9 @@ impl WorkflowMachines {
.expect("We have just ensured this is populated")
}

/// Runs the event loop, which consists of grabbing any pending outgoing commands from the
/// workflow, handling them, and preparing them to be sent off to the server.
pub(crate) fn event_loop(&mut self) {
/// Iterate the state machines, which consists of grabbing any pending outgoing commands from
/// the workflow, handling them, and preparing them to be sent off to the server.
pub(crate) fn iterate_machines(&mut self) {
let results = self.drive_me.fetch_workflow_iteration_output();
self.handle_driven_results(results);

Expand Down