Skip to content

Extend protocol to support activities #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Extend protocol to support activities #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae0adf0
Extend protocol to support activities
Mar 9, 2021
f661e8d
Update activity completion interface
vitarb Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions protos/local/core_interface.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,21 @@ message SignalWorkflow {
temporal.api.history.v1.WorkflowExecutionSignaledEventAttributes signal = 1;
}

message StartActivity {
// TODO: add attributes
}

message CancelActivity {
// TODO: add attributes
}

message ActivityTask {
// Original task from temporal service
temporal.api.workflowservice.v1.PollActivityTaskQueueResponse original = 1;
oneof job {
// Start activity execution.
StartActivity start = 1;
// Attempt to cancel activity execution.
CancelActivity cancel = 2;
}
}


Expand All @@ -129,7 +141,7 @@ message TaskCompletion {
// Complete a workflow task
WFActivationCompletion workflow = 2;
// Complete an activity task
ActivityTaskCompletion activity = 3;
ActivityResult activity = 3;
}
}

Expand All @@ -140,10 +152,11 @@ message WFActivationCompletion {
}
}

message ActivityTaskCompletion {
message ActivityResult {
oneof status {
ActivityTaskSuccess successful = 1;
ActivityTaskFailure failed = 2;
ActivityTaskSuccess completed = 1;
ActivityTaskCancelation canceled = 2;
ActivityTaskFailure failed = 3;
}
}

Expand Down Expand Up @@ -175,6 +188,10 @@ message WFActivationFailure {
// Other bits from RespondWorkflowTaskFailedRequest as needed
}

message ActivityTaskCancelation {
temporal.api.common.v1.Payloads details = 1;
}

message ActivityTaskSuccess {
temporal.api.common.v1.Payloads result = 1;
// Other bits from RespondActivityTaskCompletedRequest as needed
Expand All @@ -184,3 +201,9 @@ message ActivityTaskFailure {
temporal.api.failure.v1.Failure failure = 1;
// Other bits from RespondActivityTaskFailedRequest as needed
}

// A request as given to [crate::Core::send_activity_heartbeat]
message ActivityHeartbeat {
string activity_id = 1;
temporal.api.common.v1.Payloads details = 2;
}