Use correct JsonPath config on history serialization #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
bergundy,
cretz,
mfateev and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
history-serialization-json-path-config
branch
from
9f909bc to
42a78ae
Compare
tsurdilo
approved these changes
Feb 17, 2022
Spikhalskiy
force-pushed
the
history-serialization-json-path-config
branch
from
42a78ae to
8dd08c4
Compare
Sushisource
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Use the same JSON_PATH_CONFIGURATION during history serialization as we use during deserialization. It allows ignoring exceptions caused by the absence of the path intended for conversion in the source Json.
Why?
JsonPath upgrade performed in #1020 brought an incompatible change that requires specifying of JsonPath config to achieve an old behavior of JsonPath (ignoring an absence of a path intended for transformation). This config was originally applied in #1020 only history deserialization and left serialization broken in some cases.
How was this tested:
Added a unit test for bidirectional transformation to make sure the history serialization/deserialization works in both directions and preserves the result.