Port config of default Jackson timestamp deserialization to kotlin #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
requested review from
Sushisource,
bergundy,
cretz,
mfateev and
mmcshane
as code owners
Spikhalskiy
force-pushed
the
allign-kotlin-default-jackson-config
branch
2 times, most recently
from
b00cf0c to
2b080a6
Compare
bergundy
approved these changes
Aug 27, 2022
Code is reorganized in a way that the same basic Jackson config is used in java and kotlin modules. This also brings `mapper.configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false)` to default kotlin config that may help preventing non-deterministic problems in case replaying host has a different time zone than the original executor.
Spikhalskiy
force-pushed
the
allign-kotlin-default-jackson-config
branch
from
2b080a6 to
92a5c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Code is reorganized in a way that the same basic Jackson config is used in java and kotlin modules. This also brings
mapper.configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false)to default kotlin config that may help prevent non-deterministic problems in case the replaying host has a different time zone than the original executor.