Implement executor slots reservation for workflow tasks #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spikhalskiy
force-pushed
the
slots-reservation
branch
from
13f988b to
d7e8bf3
Compare
Spikhalskiy
requested review from
Sushisource,
bergundy,
cretz,
mfateev and
mmcshane
as code owners
Sushisource
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
This LGTM, but I'd definitely take extra care with the semaphore - I had a few problems where it'd get out of whack that I had to solve by passing around an object which represented the workflow task and when dropped would release the permit.
You've basically done that here too, and I think it looks fine, but worth running some stress tests (which I suppose is the point of this anyway)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Workflow Task pollers reserve executor slots before attempting to perform a long poll.
This behavior is now aligned with the same mechanic for activities and what happens in GoSDK & Core.
Towards #998
Closes #760