Rework WorkflowExecutorCache to remove a global lock #1454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
WorkflowExecutorCache has a global (for all workflow task processors) lock that especially comes into play when forced evictions are needed from the cache.
The only reason for this lock is to update the
cache
andinProcessing
collection in a thread-safe manner.inProcessing
in the cache is not needed, as it duplicates the functionality and the state ofWorkflowRunLockManager
that maintains all RunIds currently in-flight on the worker and does it in an effective manner for a highly concurrent environment.What
This PR removes the global lock and makes the cache to use the effective
WorkflowRunLockManager
as a source of truth of in-flight RunIds