Skip to content

Add CORS headers to the RDE Server sample implementation #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Add CORS headers to the RDE Server sample implementation #1617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions ...oral-remote-data-encoder/src/main/java/io/temporal/rde/httpserver/DataEncoderHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
import javax.servlet.http.HttpServletResponse;

class DataEncoderHandler implements HttpHandler {
public static final String ACCESS_CONTROL_ALLOW_HEADERS = "Access-Control-Allow-Headers";
public static final String ACCESS_CONTROL_ALLOW_METHODS = "Access-Control-Allow-Methods";
public static final String ACCESS_CONTROL_ALLOW_ORIGIN = "Access-Control-Allow-Origin";

private final PayloadCodec codec;

public DataEncoderHandler(List<PayloadCodec> codecs) {
Expand All @@ -43,11 +47,28 @@ public DataEncoderHandler(List<PayloadCodec> codecs) {

@Override
public void handle(HttpExchange exchange) throws IOException {
if (!exchange.getRequestMethod().equals("POST")) {
exchange.sendResponseHeaders(HttpServletResponse.SC_METHOD_NOT_ALLOWED, -1);
return;
switch (exchange.getRequestMethod()) {
case "POST":
handlePost(exchange);
break;
case "OPTIONS":
handleOptions(exchange);
break;
default:
exchange.sendResponseHeaders(HttpServletResponse.SC_METHOD_NOT_ALLOWED, -1);
}
// not in try-catch to let the server form an error response if exception occurs
exchange.close();
}

private void handleOptions(HttpExchange exchange) throws IOException {
exchange.getResponseHeaders().add(ACCESS_CONTROL_ALLOW_METHODS, "POST, OPTIONS");
exchange.getResponseHeaders().add(ACCESS_CONTROL_ALLOW_ORIGIN, "*");
exchange.getResponseHeaders().add(ACCESS_CONTROL_ALLOW_HEADERS, "*");
exchange.sendResponseHeaders(204, -1);
}

private void handlePost(HttpExchange exchange) throws IOException {
String contentType = exchange.getRequestHeaders().getFirst(HttpHeaders.CONTENT_TYPE);
if (contentType == null
|| !contentType.startsWith(AbstractRemoteDataEncoderCodec.CONTENT_TYPE_APPLICATION_JSON)) {
Expand Down Expand Up @@ -82,11 +103,12 @@ public void handle(HttpExchange exchange) throws IOException {
.getResponseHeaders()
.add(
HttpHeaders.CONTENT_TYPE, AbstractRemoteDataEncoderCodec.CONTENT_TYPE_APPLICATION_JSON);
exchange.getResponseHeaders().add(ACCESS_CONTROL_ALLOW_ORIGIN, "*");
exchange.sendResponseHeaders(HttpServletResponse.SC_OK, 0);

try (OutputStreamWriter out = new OutputStreamWriter(exchange.getResponseBody())) {
AbstractRemoteDataEncoderCodec.JSON_PRINTER.appendTo(
Payloads.newBuilder().addAllPayloads(outgoingPayloadsList).build(), out);
}
exchange.close();
}
}