Skip to content

Default schedule to start timeout #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Default schedule to start timeout #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e02c7f8
Add default sticky schedule to start timeout
vitarb Oct 30, 2020
55d8a54
Set default only when null and set zero value in tests
vitarb Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions temporal-sdk/src/main/java/io/temporal/worker/WorkerFactoryOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public static WorkerFactoryOptions getDefaultInstance() {
private static final int DEFAULT_HOST_LOCAL_WORKFLOW_POLL_THREAD_COUNT = 5;
private static final int DEFAULT_WORKFLOW_CACHE_SIZE = 600;
private static final int DEFAULT_MAX_WORKFLOW_THREAD_COUNT = 600;
private static final Duration DEFAULT_STICKY_SCHEDULE_TO_START_TIMEOUT = Duration.ofSeconds(5);

private static final WorkerFactoryOptions DEFAULT_INSTANCE;

Expand All @@ -49,6 +50,7 @@ public static WorkerFactoryOptions getDefaultInstance() {
}

public static class Builder {

private Duration workflowHostLocalTaskQueueScheduleToStartTimeout;
private int workflowCacheSize;
private int maxWorkflowThreadCount;
Expand Down Expand Up @@ -185,6 +187,9 @@ private WorkerFactoryOptions(
!workflowHostLocalTaskQueueScheduleToStartTimeout.isNegative(),
"negative workflowHostLocalTaskQueueScheduleToStartTimeoutSeconds");
}
if (workflowHostLocalTaskQueueScheduleToStartTimeout == null) {
workflowHostLocalTaskQueueScheduleToStartTimeout = DEFAULT_STICKY_SCHEDULE_TO_START_TIMEOUT;
}
if (workflowInterceptors == null) {
workflowInterceptors = new WorkflowInterceptor[0];
}
Expand Down
1 change: 1 addition & 0 deletions temporal-sdk/src/test/java/io/temporal/workflow/WorkflowTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ public WorkflowStub newUntypedWorkflowStub(
WorkerFactoryOptions.newBuilder()
.setWorkflowInterceptors(tracer)
.setActivityInterceptors(activityInterceptor)
.setWorkflowHostLocalTaskQueueScheduleToStartTimeout(Duration.ZERO)
.setWorkflowHostLocalTaskQueueScheduleToStartTimeout(
versionTest ? Duration.ZERO : Duration.ofSeconds(10))
.build();
Expand Down