Add getLastFailure method to Workflow API #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sushisource
commented
Nov 18, 2020
temporal-sdk/src/test/java/io/temporal/workflow/WorkflowTest.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Nov 21, 2020
temporal-sdk/src/main/java/io/temporal/internal/testservice/StateMachines.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/testservice/TestWorkflowMutableStateImpl.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/testservice/TestWorkflowService.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/testservice/StateMachines.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/testservice/TestWorkflowMutableStateImpl.java
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/workflow/WorkflowTest.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Nov 25, 2020
temporal-sdk/src/main/java/io/temporal/internal/testservice/StateMachines.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/testservice/TestWorkflowMutableStateImpl.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| Optional<TestServiceRetryState> retryState; | ||
| Optional<Failure> lastFailure = Optional.empty(); |
There was a problem hiding this comment.
I would move empty() initialization to else block:
Optional<Failure> lastFailure;
if (...) {
lastFailure = ...
} else {
lastFailure = Optional.empty();
}There was a problem hiding this comment.
This would require us to set it to empty in two branching paths to ensure it's non-null, thus more verbose. Any particular reason not to leave it this way?
temporal-sdk/src/main/java/io/temporal/internal/testservice/TestWorkflowMutableStateImpl.java
Outdated
Show resolved
Hide resolved
mfateev
reviewed
Nov 25, 2020
temporal-sdk/src/main/java/io/temporal/internal/testservice/StateMachines.java
Outdated
Show resolved
Hide resolved
|
Earlier you asked about time skipping logic. It is encapsulated in the SelfAdvancingTime. |
vitarb
reviewed
Dec 4, 2020
temporal-sdk/src/main/java/io/temporal/internal/sync/SyncWorkflow.java
Outdated
Show resolved
Hide resolved
vitarb
reviewed
Dec 4, 2020
Comment on lines
+1204
to
+1205
| data, | ||
| data.lastCompletionResult, |
There was a problem hiding this comment.
nit. I know you haven't changed this, but do we really need to pass both data and data.lastCompletionResult separately?
There was a problem hiding this comment.
We do - at a different call site the last completion result comes from another source.
vitarb
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR so please fill me in on anything I'm missing arch or style wise. Thanks!
Closes #257