Skip to content

Conversation

cliffsun91
Copy link

@cliffsun91 cliffsun91 commented Jan 12, 2022

It wasn't being set in the private constructor WorkflowServiceStubsOptions(Builder builder, boolean ignore).
It also seems like the parameter ignore isn't being used?

There also doesn't seem to be any existing tests for this class / builder...

What was changed

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

It wasn't being set in the private constructor `WorkflowServiceStubsOptions(Builder builder, boolean ignore)` - it also seems like `ignore` isn't being used?
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cliffsun91
Copy link
Author

Build is failing and it looks to me like it's because RpcRetryOptions$Builder.merge throws an NPE which comes from the expression Defaults.defaultValue(type).equals(options), specifically the Defaults.defaultValue(type) part where it returns null when the type is Duration.class (returns null for non-primitive) which then throws the NPE when attempting to call equals(options).

@Spikhalskiy
Copy link
Contributor

Closing in favor of #972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants