Skip to content

fix: gaap unit test #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022
Merged

fix: gaap unit test #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 7 additions & 36 deletions tencentcloud/data_source_tc_gaap_proxies_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package tencentcloud

import (
"fmt"
"regexp"
"testing"

Expand All @@ -19,7 +20,7 @@ func TestAccDataSourceTencentCloudGaapProxies_basic(t *testing.T) {
Check: resource.ComposeTestCheckFunc(
testAccCheckTencentCloudDataSourceID("data.tencentcloud_gaap_proxies.foo"),
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_proxies.foo", "proxies.0.id"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_proxies.foo", "proxies.0.name", "ci-test-gaap-proxy"),
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_proxies.foo", "proxies.0.name"),
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_proxies.foo", "proxies.0.domain"),
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_proxies.foo", "proxies.0.ip"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_proxies.foo", "proxies.0.bandwidth", "10"),
Expand Down Expand Up @@ -113,58 +114,28 @@ func TestAccDataSourceTencentCloudGaapProxies_filter(t *testing.T) {
})
}

const TestAccDataSourceTencentCloudGaapProxiesBasic = `
resource tencentcloud_gaap_proxy "foo" {
name = "ci-test-gaap-proxy"
bandwidth = 10
concurrent = 2
access_region = "Guangzhou"
realserver_region = "Beijing"
}

var TestAccDataSourceTencentCloudGaapProxiesBasic = fmt.Sprintf(`
data tencentcloud_gaap_proxies "foo" {
ids = [tencentcloud_gaap_proxy.foo.id]
ids = ["%s"]
}
`
`, defaultGaapProxyId)

const TestAccDataSourceTencentCloudGaapProxiesProjectId = `
resource tencentcloud_gaap_proxy "foo" {
name = "ci-test-gaap-proxy"
bandwidth = 10
concurrent = 2
access_region = "Guangzhou"
realserver_region = "Beijing"
}

data tencentcloud_gaap_proxies "projectId" {
project_id = 0
}
`

const TestAccDataSourceTencentCloudGaapProxiesAccessRegion = `
resource tencentcloud_gaap_proxy "foo" {
name = "ci-test-gaap-proxy"
bandwidth = 10
concurrent = 2
access_region = "Guangzhou"
realserver_region = "Beijing"
}

data tencentcloud_gaap_proxies "access" {
access_region = tencentcloud_gaap_proxy.foo.access_region
access_region = "Guangzhou"
}
`

const TestAccDataSourceTencentCloudGaapProxiesRealserverRegion = `
resource tencentcloud_gaap_proxy "foo" {
name = "ci-test-gaap-proxy"
bandwidth = 10
concurrent = 2
access_region = "Guangzhou"
realserver_region = "Beijing"
}

data tencentcloud_gaap_proxies "realserver" {
realserver_region = tencentcloud_gaap_proxy.foo.realserver_region
realserver_region = "Beijing"
}
`
16 changes: 8 additions & 8 deletions tencentcloud/data_source_tc_gaap_security_rules_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func TestAccDataSourceTencentCloudGaapSecurityRules_multi(t *testing.T) {
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_security_rules.ruleId", "rules.0.id"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_security_rules.ruleId", "rules.0.cidr_ip", "1.1.1.1"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_security_rules.ruleId", "rules.0.name", "ci-test-gaap-s-rule"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_security_rules.ruleId", "rules.0.port", "80"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_security_rules.ruleId", "rules.0.port", "8120"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_security_rules.ruleId", "rules.0.protocol", "TCP"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_security_rules.ruleId", "rules.0.action", "ACCEPT"),
),
Expand Down Expand Up @@ -97,7 +97,7 @@ func TestAccDataSourceTencentCloudGaapSecurityRules_multi(t *testing.T) {
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_security_rules.port", "rules.0.id"),
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_security_rules.port", "rules.0.cidr_ip"),
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_security_rules.port", "rules.0.name"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_security_rules.port", "rules.0.port", "80"),
resource.TestCheckResourceAttr("data.tencentcloud_gaap_security_rules.port", "rules.0.port", "8120"),
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_security_rules.port", "rules.0.protocol"),
resource.TestCheckResourceAttrSet("data.tencentcloud_gaap_security_rules.port", "rules.0.action"),
),
Expand Down Expand Up @@ -143,7 +143,7 @@ resource tencentcloud_gaap_security_rule "foo" {
cidr_ip = "1.1.1.1"
action = "ACCEPT"
protocol = "TCP"
port = "80"
port = "8120"
}

data tencentcloud_gaap_security_rules "ruleId" {
Expand All @@ -159,7 +159,7 @@ resource tencentcloud_gaap_security_rule "foo" {
cidr_ip = "1.1.1.1"
action = "ACCEPT"
protocol = "TCP"
port = "80"
port = "8120"
}

data tencentcloud_gaap_security_rules "action" {
Expand All @@ -175,7 +175,7 @@ resource tencentcloud_gaap_security_rule "foo" {
cidr_ip = "1.1.1.1"
action = "ACCEPT"
protocol = "TCP"
port = "80"
port = "8120"
}

data tencentcloud_gaap_security_rules "cidrIp" {
Expand All @@ -192,7 +192,7 @@ resource tencentcloud_gaap_security_rule "foo" {
cidr_ip = "1.1.1.1"
action = "ACCEPT"
protocol = "TCP"
port = "80"
port = "8120"
}

data tencentcloud_gaap_security_rules "name" {
Expand All @@ -209,7 +209,7 @@ resource tencentcloud_gaap_security_rule "foo" {
cidr_ip = "1.1.1.1"
action = "ACCEPT"
protocol = "TCP"
port = "80"
port = "8120"
}

data tencentcloud_gaap_security_rules "port" {
Expand All @@ -226,7 +226,7 @@ resource tencentcloud_gaap_security_rule "foo" {
cidr_ip = "1.1.1.1"
action = "ACCEPT"
protocol = "TCP"
port = "80"
port = "8120"
}

data tencentcloud_gaap_security_rules "protocol" {
Expand Down