feat: tke - support separate tke cluster endpoint resource switch #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellertang
reviewed
Jul 6, 2022
| if err != nil { | ||
| errs = *multierror.Append(err) | ||
| } else { | ||
| taskErr := waitForClusterEndpointFinish(ctx, &service, id, false, isManagedCluster) |
Collaborator
There was a problem hiding this comment.
这个地方有点疑问。
我们创建NodePool的时候，会等待节点池中的节点是否已经ready么？
如果上面不会等待，这边的轮询是不是大部分时间在等待节点池中节点ready?
Contributor
Author
There was a problem hiding this comment.
- 不会
- 等待的是 Task status 状态变化，至于这个状态是否根据集群内节点的有无而变化，这个还没有确认
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.