Skip to content

fix update cvm instance tags #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix update cvm instance tags #1134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tencentcloud/resource_tc_instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,8 +1399,9 @@ func resourceTencentCloudInstanceUpdate(d *schema.ResourceData, meta interface{}
}
//tag disk ids
if dataDisks, ok := d.GetOk("data_disks"); ok {
dataDiskList := dataDisks.([]map[string]interface{})
for _, disk := range dataDiskList {
dataDiskList := dataDisks.([]interface{})
for _, dataDisk := range dataDiskList {
disk := dataDisk.(map[string]interface{})
dataDiskId := disk["data_disk_id"].(string)
resourceName = BuildTagResourceName("cvm", "volume", region, dataDiskId)
if err := tagService.ModifyTags(ctx, resourceName, replaceTags, deleteTags); err != nil {
Expand Down
6 changes: 5 additions & 1 deletion tencentcloud/resource_tc_instance_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,11 @@ resource "tencentcloud_instance" "foo" {
image_id = data.tencentcloud_images.default.images.0.image_id
instance_type = data.tencentcloud_instance_types.default.instance_types.0.instance_type
system_disk_type = "CLOUD_PREMIUM"

data_disks {
data_disk_type = "CLOUD_PREMIUM"
data_disk_size = 150
delete_with_instance = true
}
tags = %s
}
`,
Expand Down