Skip to content

fix: eip read not support internet_charge_type #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2022
Merged

fix: eip read not support internet_charge_type #1240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92d628d
fix: eip read not support internet_charge_type
Aug 29, 2022
093250b
update
Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tencentcloud/resource_tc_eip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ func resourceTencentCloudEip() *schema.Resource {
"internet_charge_type": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ForceNew: true,
ValidateFunc: validateAllowedStringValue(CVM_INTERNET_CHARGE_TYPE),
Description: "The charge type of eip. Valid value: `BANDWIDTH_PACKAGE`, `BANDWIDTH_POSTPAID_BY_HOUR` and `TRAFFIC_POSTPAID_BY_HOUR`.",
Expand Down Expand Up @@ -241,6 +242,7 @@ func resourceTencentCloudEipRead(d *schema.ResourceData, meta interface{}) error
_ = d.Set("type", eip.AddressType)
_ = d.Set("public_ip", eip.AddressIp)
_ = d.Set("status", eip.AddressStatus)
_ = d.Set("internet_charge_type", eip.InternetChargeType)
_ = d.Set("tags", tags)
return nil
}
Expand Down
30 changes: 30 additions & 0 deletions tencentcloud/resource_tc_eip_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,29 @@ func TestAccTencentCloudEip_bandwidth(t *testing.T) {
})
}

func TestAccTencentCloudEip_chargetype(t *testing.T) {
t.Parallel()
resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckEipDestroy,
Steps: []resource.TestStep{
{
Config: testAccEipChargeType,
Check: resource.ComposeTestCheckFunc(
testAccCheckEipExists("tencentcloud_eip.foo"),
resource.TestCheckResourceAttr("tencentcloud_eip.foo", "internet_charge_type", "TRAFFIC_POSTPAID_BY_HOUR"),
),
},
{
ResourceName: "tencentcloud_eip.foo",
ImportState: true,
ImportStateVerify: true,
},
},
})
}

func testAccCheckEipExists(n string) resource.TestCheckFunc {
return func(s *terraform.State) error {
logId := getLogId(contextNil)
Expand Down Expand Up @@ -312,3 +335,10 @@ resource "tencentcloud_eip" "foo" {
internet_max_bandwidth_out = 2
}
`

const testAccEipChargeType = `
resource "tencentcloud_eip" "foo" {
name = "eip_charge_type"
internet_charge_type = "TRAFFIC_POSTPAID_BY_HOUR"
}
`