Skip to content

Conversation

@gitmkn
Copy link
Collaborator

@gitmkn gitmkn commented Sep 20, 2022

teo support change

gitmkn and others added 30 commits September 14, 2022 10:44
1. some docs.
2. delete tencentcloud_teo_security_policy_regions `country_en` and `continent_en`.
3. delete tencentcloud_teo_waf_managed_rules
4. tencentcloud_teo_zone_available_plans add `area`.
5. fix tencentcloud_teo_application_proxy build error.
6. fix tencentcloud_teo_zone `plan_type`.
…provider-tencentcloud into fix/teo-support-change
…provider-tencentcloud into fix/teo-support-change
…provider-tencentcloud into fix/teo-support-change
@gitmkn gitmkn requested a review from hellertang September 20, 2022 07:32
_ = d.Set("rules", ruleList)
}

d.SetId("bot_managed_rules")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样会有问题啊

_ = d.Set("rules", ruleList)
}

d.SetId("bot_managed_rules")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dasource这样写是有问题的。
如果不同zoneId和entity下面的rules了?就需要写不同的datasource
这样id就冲突了
其它的一样

Copy link
Collaborator

@hellertang hellertang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@hellertang hellertang merged commit 007f4bc into tencentcloudstack:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants