support env for SESSION_DURATION #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellertang
reviewed
Oct 12, 2022
website/docs/index.html.markdown
Outdated
| ``` | ||
|
|
||
| The `assume_role_arn`, `assume_role_session_name`, `assume_role_session_duration` can also provided via `TENCENTCLOUD_ASSUME_ROLE_ARN`, `TENCENTCLOUD_ASSUME_ROLE_SESSION_NAME` and `TENCENTCLOUD_ASSUME_ROLE_SESSION_DURATION` environment variables. | ||
| The `assume_role_arn`, `assume_role_session_name`, `assume_role_session_duration` can also provided via `TENCENTCLOUD_ASSUME_ROLE_ARN`, `TENCENTCLOUD_ASSUME_ROLE_SESSION_NAME` and `TENCENTCLOUD_ASSUME_ROLE_SESSION_DURATION` environment variables with a empty `assume_role` block. |
Contributor
Author
There was a problem hiding this comment.
按目前providerConfigure逻辑，如果不加这个空block，即便配置了环境变量，压根儿就不会取assume_role_arn, assume_role_session_name, assume_role_session_duration这几个字段。
providerConfigure逻辑如下：
tencentcloud/provider.go:1282:
assumeRoleList := d.Get("assume_role").(*schema.Set).List() if len(assumeRoleList) == 1 {
Contributor
Author
There was a problem hiding this comment.
当然还有一个实现就是修改providerConfigure逻辑。
if len(assumeRoleList) == 0时，尝试取环境变量。
就不需要放这个空block。
hellertang
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.