feat:users can delete TKE cluster audit logs and event persistence logs #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kagashino
reviewed
Dec 1, 2022
| ctx := context.WithValue(context.TODO(), logIdKey, logId) | ||
| service := TkeService{client: meta.(*TencentCloudClient).apiV3Conn} | ||
|
|
||
| if v, ok := helper.InterfacesHeadMap(d, "event_persistence"); ok { |
Contributor
There was a problem hiding this comment.
假设用户删除之前持久化是 Disabled 的，这里再调用 Disable 会不会报错？
added 2 commits
December 1, 2022 19:25
…eleting tke cluster event persistence logs
Kagashino
reviewed
Dec 2, 2022
|
|
||
| func (me *TkeService) SwitchEventPersistence(ctx context.Context, clusterId, logSetId, topicId string, enable bool) error { | ||
| func (me *TkeService) SwitchEventPersistence(ctx context.Context, clusterId, logSetId, topicId string, | ||
| enable, deleteEventLog bool, d *schema.ResourceData) error { |
Contributor
There was a problem hiding this comment.
ResourceData 尽量避免下放到 service 文件中处理，尽管每次都需要判断
Contributor
Author
There was a problem hiding this comment.
ok,我提到上层，是的，每次都要去判断，我才下放到service的
| return me.EnableEventPersistence(ctx, request) | ||
| } | ||
| if !enable { | ||
| oldConf, _ := d.GetChange("event_persistence") |
Contributor
There was a problem hiding this comment.
Destroy 的状态判断应该以当前值为准，GetChange 仅为修改代码时有意义， d.GetOk / d.GetChange 就行了
Contributor
Author
There was a problem hiding this comment.
我用的是GetChange啊。你说的当前值是什么意思，要通过查询接口查询一下当前的状态吗
added 4 commits
December 2, 2022 18:21
… enable value of the cluster persistence log is modified
…e logs for the tke cluster
Kagashino
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you delete a TKE cluster, disable the cluster audit log, and disable the cluster event log, you can choose whether to delete the audit and event log sets and topics created by default