Skip to content

Feat/adjust tcr tag retention e2e #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 12, 2023
Merged

Feat/adjust tcr tag retention e2e #1955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4b7ad9a
example readjust: tencentcloud_kubernetes_serverless_node_pool
lyu571 Jul 5, 2023
2ed70ac
Merge branch 'master' of github.com:tencentcloudstack/terraform-provi…
lyu571 Jul 5, 2023
6f9057d
Merge branch 'master' of github.com:tencentcloudstack/terraform-provi…
lyu571 Jul 6, 2023
1de956a
Merge branch 'master' of github.com:tencentcloudstack/terraform-provi…
lyu571 Jul 6, 2023
f3dd2e4
Merge branch 'master' of github.com:tencentcloudstack/terraform-provi…
lyu571 Jul 7, 2023
d9c1df2
Merge branch 'master' of github.com:tencentcloudstack/terraform-provi…
lyu571 Jul 10, 2023
9fd5fdd
add pre-commit-local
lyu571 Jul 11, 2023
391c9bd
Merge branch 'master' of github.com:tencentcloudstack/terraform-provi…
lyu571 Jul 11, 2023
316e249
Merge branch 'master' of github.com:tencentcloudstack/terraform-provi…
lyu571 Jul 12, 2023
f043ca7
adjust e2e case
lyu571 Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tencentcloud/resource_tc_tcr_tag_retention_execution_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const testAccTcrTagRetentionRule_manual = testAccTCRInstance_retention + `

resource "tencentcloud_tcr_namespace" "my_ns" {
instance_id = tencentcloud_tcr_instance.mytcr_retention.id
name = "tf_test_ns_retention"
name = "tf_test_ns_retention_config"
is_public = true
is_auto_scan = true
is_prevent_vul = true
Expand Down
8 changes: 4 additions & 4 deletions tencentcloud/resource_tc_tcr_tag_retention_rule_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ func TestAccTencentCloudTcrTagRetentionRuleResource_basic(t *testing.T) {
testAccCheckTCRTagRetentionRuleExists("tencentcloud_tcr_tag_retention_rule.my_rule"),
resource.TestCheckResourceAttrSet("tencentcloud_tcr_tag_retention_rule.my_rule", "id"),
resource.TestCheckResourceAttrSet("tencentcloud_tcr_tag_retention_rule.my_rule", "registry_id"),
resource.TestCheckResourceAttr("tencentcloud_tcr_tag_retention_rule.my_rule", "namespace_name", "tf_test_ns_retention"),
resource.TestCheckResourceAttr("tencentcloud_tcr_tag_retention_rule.my_rule", "namespace_name", "tf_test_ns_retention_rule"),
resource.TestCheckResourceAttrSet("tencentcloud_tcr_tag_retention_rule.my_rule", "retention_rule.#"),
resource.TestCheckResourceAttr("tencentcloud_tcr_tag_retention_rule.my_rule", "retention_rule.0.key", "nDaysSinceLastPush"),
resource.TestCheckResourceAttr("tencentcloud_tcr_tag_retention_rule.my_rule", "retention_rule.0.value", "1"),
Expand All @@ -46,7 +46,7 @@ func TestAccTencentCloudTcrTagRetentionRuleResource_basic(t *testing.T) {
testAccCheckTCRTagRetentionRuleExists("tencentcloud_tcr_tag_retention_rule.my_rule"),
resource.TestCheckResourceAttrSet("tencentcloud_tcr_tag_retention_rule.my_rule", "id"),
resource.TestCheckResourceAttrSet("tencentcloud_tcr_tag_retention_rule.my_rule", "registry_id"),
resource.TestCheckResourceAttr("tencentcloud_tcr_tag_retention_rule.my_rule", "namespace_name", "tf_test_ns_retention"),
resource.TestCheckResourceAttr("tencentcloud_tcr_tag_retention_rule.my_rule", "namespace_name", "tf_test_ns_retention_rule"),
resource.TestCheckResourceAttrSet("tencentcloud_tcr_tag_retention_rule.my_rule", "retention_rule.#"),
resource.TestCheckResourceAttr("tencentcloud_tcr_tag_retention_rule.my_rule", "retention_rule.0.key", "nDaysSinceLastPush"),
resource.TestCheckResourceAttr("tencentcloud_tcr_tag_retention_rule.my_rule", "retention_rule.0.value", "2"),
Expand Down Expand Up @@ -152,7 +152,7 @@ const testAccTcrTagRetentionRule = testAccTCRInstance_retention + `

resource "tencentcloud_tcr_namespace" "my_ns" {
instance_id = tencentcloud_tcr_instance.mytcr_retention.id
name = "tf_test_ns_retention"
name = "tf_test_ns_retention_rule"
is_public = true
is_auto_scan = true
is_prevent_vul = true
Expand All @@ -179,7 +179,7 @@ const testAccTcrTagRetentionRule_update = testAccTCRInstance_retention + `

resource "tencentcloud_tcr_namespace" "my_ns" {
instance_id = tencentcloud_tcr_instance.mytcr_retention.id
name = "tf_test_ns_retention"
name = "tf_test_ns_retention_rule"
is_public = true
is_auto_scan = true
is_prevent_vul = true
Expand Down