fix cvm creation while its tags not sync issue #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Himer
reviewed
Jul 2, 2020
Himer
reviewed
Jul 2, 2020
When cvm created success, its tags may not attached at once, since it's async. We use a dedicated [tag](https://cloud.tencent.com/document/api/651/35326) api to attach and makes its behavior like a sync one.
longkai
force-pushed
the
fix-cvm-tag-async
branch
from
195571b to
ff37fde
Compare
Himer
reviewed
Jul 3, 2020
- use `helper.GetTags` to do with tags uniformly - use `BuildTagResourceName` to build resource name uniformly
If new tag api call failed, the user will be notified and tack actions with terraform
likexian
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cvm created success, its tags may not attached at once, since it's async.
We use a dedicated tag api to attach and makes its behavior like a sync one.