Skip to content

add keep_image_login with resource CVM #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 14, 2020
Merged

add keep_image_login with resource CVM #527

merged 6 commits into from
Oct 14, 2020

Conversation

@gailwang
Copy link
Contributor

@gailwang gailwang commented Oct 9, 2020 

make testacc TESTARGS=" -run=TestAccTencentCloudInstanceWithImageLogin"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccTencentCloudInstanceWithImageLogin -timeout 120m
?       github.com/tencentcloudstack/terraform-provider-tencentcloud    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/tencentcloudstack/terraform-provider-tencentcloud/gendoc    (cached) [no tests to run]
=== RUN   TestAccTencentCloudInstanceWithImageLogin
=== PAUSE TestAccTencentCloudInstanceWithImageLogin
=== CONT  TestAccTencentCloudInstanceWithImageLogin
--- PASS: TestAccTencentCloudInstanceWithImageLogin (66.27s)
PASS
ok      github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud       67.669s
?       github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/connectivity  [no test files]
?       github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/internal/helper       [no test files]
?       github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/ratelimit     [no test files]

brickzzhang
brickzzhang reviewed Oct 10, 2020
View reviewed changes
tencentcloud/resource_tc_instance.go Outdated
if v, ok := d.GetOk("password"); ok {
request.LoginSettings.Password = helper.String(v.(string))
}
if v, ok := d.GetOkExists("keep_image_login"); ok {
Copy link
Contributor

@brickzzhang brickzzhang Oct 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default字段，直接get哇

Copy link
Contributor Author

@gailwang gailwang Oct 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有道理

oliverpei
oliverpei reviewed Oct 14, 2020
View reviewed changes
tencentcloud/resource_tc_instance_test.go Outdated
)
}

func testAccTencentCloudInstanceWithImageLogin() string {
Copy link
Contributor

@oliverpei oliverpei Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以直接写个const string，没必要写函数

@oliverpei oliverpei merged commit d6b21d5 into tencentcloudstack:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@brickzzhang brickzzhang brickzzhang approved these changes

@oliverpei oliverpei oliverpei approved these changes

@crab21 crab21 crab21 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gailwang @brickzzhang @oliverpei @crab21