Skip to content

Feat/add timeout env #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Feat/add timeout env #826

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
410ed00
add timeout env
hellertang Jan 11, 2022
d45005a
remove debug info
hellertang Jan 11, 2022
5b74906
add panic
hellertang Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions tencentcloud/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"os"
"os/user"
"reflect"
"strconv"
"strings"
"sync/atomic"
"time"
Expand All @@ -27,14 +28,23 @@ type contextLogId string

const logIdKey = contextLogId("logId")

const (
PROVIDER_READ_RETRY_TIMEOUT = "TENCENTCLOUD_READ_RETRY_TIMEOUT"
PROVIDER_WRITE_RETRY_TIMEOUT = "TENCENTCLOUD_WRITE_RETRY_TIMEOUT"
)

var logFirstTime = ""
var logAtomicId int64 = 0

// readRetryTimeout is read retry timeout
const readRetryTimeout = 3 * time.Minute
//const readRetryTimeout = 3 * time.Minute
var readRetry = getEnvDefault(PROVIDER_READ_RETRY_TIMEOUT, 3)
var readRetryTimeout = time.Duration(readRetry) * time.Minute

// writeRetryTimeout is write retry timeout
const writeRetryTimeout = 5 * time.Minute
//const writeRetryTimeout = 5 * time.Minute
var writeRetry = getEnvDefault(PROVIDER_WRITE_RETRY_TIMEOUT, 5)
var writeRetryTimeout = time.Duration(writeRetry) * time.Minute

// InternalError common internalError, do not add in retryableErrorCode,
// because when some product return this error, retry won't fix anything.
Expand All @@ -59,6 +69,18 @@ func init() {
logFirstTime = fmt.Sprintf("%d", time.Now().UnixNano()/int64(time.Millisecond))
}

func getEnvDefault(key string, defVal int) int {
val, ex := os.LookupEnv(key)
if !ex {
return defVal
}
int, err := strconv.Atoi(val)
if err != nil {
panic("TENCENTCLOUD_READ_RETRY_TIMEOUT or TENCENTCLOUD_WRITE_RETRY_TIMEOUT must be int.")
}
return int
}

// getLogId get logId for trace, return a new logId if ctx is nil
func getLogId(ctx context.Context) string {
if ctx != nil {
Expand Down