Skip to content

fix: eip unit test #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2022
Merged

fix: eip unit test #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd3ec1
fix: eip unit test
Mar 30, 2022
e94ae61
fix: fmt resource_tc_vpn_ssl_client.go
Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tencentcloud/resource_tc_eip_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package tencentcloud
import (
"context"
"fmt"
"os"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
Expand Down Expand Up @@ -72,6 +73,10 @@ func TestAccTencentCloudEip_basic(t *testing.T) {

func TestAccTencentCloudEip_anycast(t *testing.T) {
t.Parallel()
defer func() {
os.Setenv(PROVIDER_REGION, "")
}()
os.Setenv(PROVIDER_REGION, "ap-hongkong")
resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
Expand Down Expand Up @@ -234,14 +239,14 @@ const testAccEipAnycast = `
resource "tencentcloud_eip" "foo" {
name = "eip_anycast"
type = "AnycastEIP"
anycast_zone = "ANYCAST_ZONE_GLOBAL"
anycast_zone = "ANYCAST_ZONE_OVERSEAS"
}
`

const testAccEipProvider = `
resource "tencentcloud_eip" "foo" {
name = "eip_provider"
internet_service_provider = "CMCC"
internet_service_provider = "CUCC"
}
`

Expand Down
2 changes: 1 addition & 1 deletion tencentcloud/resource_tc_vpn_ssl_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func resourceTencentCloudVpnSslClientCreate(d *schema.ResourceData, meta interfa
return fmt.Errorf("get instance list error: %s", err.Error())
}
if len(newIns) != 1 {
return fmt.Errorf("create ssl client error")
return fmt.Errorf("create ssl client error")
}

sslClient := newIns[0]
Expand Down
2 changes: 1 addition & 1 deletion tencentcloud/service_tencentcloud_vpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2128,7 +2128,7 @@ func (me *VpcService) UnattachEip(ctx context.Context, eipId string) error {
}

// DisassociateAddress Doesn't support Disassociate NAT Address
if strings.HasPrefix(*eip.InstanceId, "nat-") {
if eip.InstanceId != nil && strings.HasPrefix(*eip.InstanceId, "nat-") {
request := vpc.NewDisassociateNatGatewayAddressRequest()
request.NatGatewayId = eip.InstanceId
request.PublicIpAddresses = []*string{eip.AddressIp}
Expand Down