Skip to content

fix expries may be null #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2020
Merged

fix expries may be null #153

merged 1 commit into from
Aug 7, 2020

Conversation

@Tabll
Copy link
Contributor

@Tabll Tabll commented Jun 17, 2020

expires 在外面调用的默认值是 null

(string)(strtotime(null) 会是一个空值，会导致过期时间为空
这样生成的链接访问的时候报超时错误:

<Error>
<Code>AccessDenied</Code>
<Message>Request has expired</Message>
<ServerTime>2020-06-17T05:37:29Z</ServerTime>

建议判断一下 expires 是否为空

lewzylu
lewzylu approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@lewzylu lewzylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lewzylu lewzylu merged commit f6e13d8 into tencentyun:master Aug 7, 2020
@lewzylu
Copy link
Contributor

lewzylu commented Aug 7, 2020

感谢您的建议

sy-records pushed a commit to sy-records/cos-php-sdk-v5 that referenced this pull request Sep 16, 2020
@Tabll @sy-records
fix expries may be null (tencentyun#153)
74ae466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lewzylu lewzylu lewzylu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tabll @lewzylu