Skip to content

add input argument check #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021
Merged

add input argument check #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/Qcloud/Cos/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Qcloud\Cos;

use Exception;
use Qcloud\Cos\Signature;
use GuzzleHttp\Client as HttpClient;
use GuzzleHttp\HandlerStack;
Expand All @@ -16,6 +17,7 @@
use GuzzleHttp\Exception\ConnectException;
use GuzzleHttp\Middleware;
use GuzzleHttp\Psr7;
use Qcloud\Cos\Exception\CosException;

/**
* @method object AbortMultipartUpload (array $arg)
Expand Down Expand Up @@ -105,7 +107,7 @@ class Client extends GuzzleClient {
public function __construct($cosConfig) {
$this->rawCosConfig = $cosConfig;
$this->cosConfig['schema'] = isset($cosConfig['schema']) ? $cosConfig['schema'] : 'http';
$this->cosConfig['region'] = region_map($cosConfig['region']);
$this->cosConfig['region'] = isset($cosConfig['region']) ? region_map($cosConfig['region']) : null;
$this->cosConfig['appId'] = isset($cosConfig['credentials']['appId']) ? $cosConfig['credentials']['appId'] : null;
$this->cosConfig['secretId'] = isset($cosConfig['credentials']['secretId']) ? $cosConfig['credentials']['secretId'] : "";
$this->cosConfig['secretKey'] = isset($cosConfig['credentials']['secretKey']) ? $cosConfig['credentials']['secretKey'] : "";
Expand All @@ -122,7 +124,11 @@ public function __construct($cosConfig) {
$this->cosConfig['userAgent'] = isset($cosConfig['userAgent']) ? $cosConfig['userAgent'] : 'cos-php-sdk-v5.'. Client::VERSION;
$this->cosConfig['pathStyle'] = isset($cosConfig['pathStyle']) ? $cosConfig['pathStyle'] : false;
$this->cosConfig['allow_redirects'] = isset($cosConfig['allow_redirects']) ? $cosConfig['allow_redirects'] : false;

try {
$this->inputCheck();
} catch (\Exception $e) {
throw($e);
}
$service = Service::getService();
$handler = HandlerStack::create();
$handler->push(Middleware::retry($this->retryDecide(), $this->retryDelay()));
Expand Down Expand Up @@ -152,6 +158,19 @@ public function __construct($cosConfig) {
'commandToRequestTransformer'], [$this, 'responseToResultTransformer'],
null);
}

public function inputCheck() {
if ($this->cosConfig['region'] == null &&
$this->cosConfig['domain'] == null &&
$this->cosConfig['endpoint'] == null &&
$this->cosConfig['ip'] == null) {
$e = new \Qcloud\Cos\Exception\CosException("Region is empty");
$e->setExceptionCode("Invalid Argument");
throw $e;
}
}


public function retryDecide() {
return function (
$retries,
Expand Down