Skip to content

Move markdown-it to dependencies from devdependencies #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lovincyrus merged 2 commits into from
May 15, 2020
Merged

Move markdown-it to dependencies from devdependencies #179

lovincyrus merged 2 commits into from
May 15, 2020

Conversation

@fadeev
Copy link
Contributor

@fadeev fadeev commented May 11, 2020 •
edited
Loading

Markdown-it is used by several components during runtime, but it included as a dev dependency.

Screenshot 2020-05-11 at 14 29 28

Also replaced width with max-width, so that maxWidth prop value is reflected in the max width of the sheet.

@fadeev fadeev requested a review from lovincyrus as a code owner May 11, 2020 09:38
lovincyrus
lovincyrus approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@lovincyrus lovincyrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@lovincyrus lovincyrus merged commit 0e23d88 into develop May 15, 2020
@lovincyrus lovincyrus deleted the fadeev/markdown-dep branch May 15, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lovincyrus lovincyrus lovincyrus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fadeev @lovincyrus