This repository was archived by the owner on Feb 23, 2022. It is now read-only.
apps.md fixups #341
Merged
apps.md fixups #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williambanfield
commented
Sep 1, 2021
| Must have `MaxGas >= -1`. | ||
| If `MaxGas == -1`, no limit is enforced. | ||
|
|
||
| ### BlockParams.TimeIotaMs |
williambanfield
commented
Sep 1, 2021
williambanfield
commented
Sep 1, 2021
williambanfield
commented
Sep 1, 2021
| -- this feels go specific | ||
| If there are cases in your application where a transaction may become invalid in some | ||
| future state, you probably want to disable Tendermint's | ||
| cache. You can do that by setting `[mempool] cache_size = 0` in the |
Contributor
Author
There was a problem hiding this comment.
This is a go-specific setting, not really a specification.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
tac0turtle
reviewed
Sep 17, 2021
Contributor
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
is this ready to be merged?
williambanfield
requested review from
ebuchman,
josef-widder,
konnov and
milosevic
as code owners
creachadair
approved these changes
Sep 17, 2021
Contributor
creachadair
left a comment
creachadair
left a comment
There was a problem hiding this comment.
A few suggestions, but nothing blocking.
williambanfield
commented
Sep 17, 2021
Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests offers several fixups to the apps.md document. The changes are primarily in areas that I found somewhat unclear or where language needed to be modified to reflect the more current state of the system. An example of this is the recent rename of fast sync to 'block sync'.