Skip to content

Conversation

@Infinoid
Copy link
Contributor

Currently, cmake's make install rule ignores the python bindings. CMake puts the built shared object directly into the pytaco source folder.

This patch stages the .py files and .so file in the build folder, and installs them during make install. The results look like this:

/usr/local/lib
/usr/local/lib/libtaco.so
/usr/local/lib/pytaco
/usr/local/lib/pytaco/__init__.py
/usr/local/lib/pytaco/pytensor
/usr/local/lib/pytaco/pytensor/__init__.py
/usr/local/lib/pytaco/pytensor/taco_tensor.py
/usr/local/lib/pytaco/pytensor/tensorIO.py
/usr/local/lib/pytaco/core
/usr/local/lib/pytaco/core/core_modules.cpython-36m-x86_64-linux-gnu.so

The staging of .py and .so files in the build folder will be useful for fixing make test, which is next on my list.

@stephenchouca stephenchouca merged commit 690687c into tensor-compiler:master Jun 16, 2020
@Infinoid Infinoid deleted the cmake-install-python-bindings branch June 16, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants