tensor,codegen: fix a bug where kernel cache could be modified #376
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where upon recompilation of an index statement, entries in the kernel cache could be inadvertently modified, leading to confusing segfaults. An example of the bug is included in the added test, where the second call to `c(i, j) = a(i, j)` would hit the cache, but then find a module that had code that corresponded to `c(i, j) = a(i, j) + b(i, j)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where upon recompilation of an index statement,
entries in the kernel cache could be inadvertently modified, leading to
confusing segfaults.
An example of the bug is included in the added test, where the second
call to
c(i, j) = a(i, j)would hit the cache, but then find a modulethat had code that corresponded to
c(i, j) = a(i, j) + b(i, j).