Qudit infras #42
Merged
Qudit infras #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… While a qudit in |10> state, it will be shown as `A` from _ALPHBET.
…l the functions are now avaliable for any d-dimensional systems. Add _infer_num_sites() for inferring the site number in d-dimensional system.
…qudit gates. And optimized some code writing.
…rcuit is now suitable to do general calculation for d-dimensional systems.
…as matrix(), get_quoperator() method), add a _qudit attribute to abstractcircuit.py, defaulting to False.
refraction-ray
requested changes
Aug 30, 2025
Member
|
please add some tests for these changed functions with d>2, some may require d>10, also be consistent with the variable name: d or dim |
# Conflicts: # tensorcircuit/basecircuit.py # tensorcircuit/quantum.py
refraction-ray
requested changes
Sep 2, 2025
refraction-ray
requested changes
Sep 2, 2025
Member
refraction-ray
left a comment
refraction-ray
left a comment
There was a problem hiding this comment.
In general looks nice, the pr can be merged after fixing the following minor points
| ind = backend.probability_sample( | ||
| shots=1, | ||
| p=backend.cast(pu, rdtypestr), | ||
| status=one_r - st, |
Member
There was a problem hiding this comment.
why one_r-st instead of st?
Contributor
Author
There was a problem hiding this comment.
Because probability_sample internally uses 1 - status when mapping uniform random numbers to the CDF, passing one_r - st ensures the sampling behavior stays consistent with the original implicit_randc/CDF logic.
Member
|
LGTM now, will merge if there is no CI error |
Contributor
Author
|
Great, it seems that the program has passed the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains extensive preliminary work for quditcircuit, including:
1. Removing and improving a large amount of hard-coded logic based on qubit systems with dimension 2, replacing it with a general dimension d;
2. Preserving the efficient sampling method for d = 2, while providing an if branch for cases where d != 2;
3. Updating the state labeling scheme from standard binary to a base-d representation using 0–9A–Z;
4. Adjusting the hard-coded parts in MPSCircuit and densitycircuit to ensure their functionality as qudit backends in the future, while currently forbidding the direct creation of qudits with d != 2 from mpscircuit and densitycircuit.