fix typing of num_updates in moving_average #2136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindQAQ
requested changes
Aug 30, 2020
Member
WindQAQ
left a comment
WindQAQ
left a comment
There was a problem hiding this comment.
Thanks for the contribution 😃
| self._num_updates, | ||
| ( | ||
| 'type of argument "num_updates" must be ' | ||
| + f"int; got {self._num_updates.dtype} instead" |
Member
There was a problem hiding this comment.
We are compatible with Python3.5, so fstring should be avoided.
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* fix typing of num_updates in moving_average * use .format instead of fstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2113
Type of change
Checklist:
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes: By running
python -m pytest tensorflow_addons/optimizers/tests/moving_average_test.py