Skip to content

unify activations and tests #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 3, 2019
Merged

unify activations and tests #551

merged 8 commits into from
Oct 3, 2019

Conversation

@WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Sep 30, 2019

  • Remove name arg for sparsemax
  • Test theoretical gradients only
  • Test outputs against numerical values instead of reference function
  • Move serialization test to standalone file to reduce duplicated codes
  • CC trivial fix

@WindQAQ WindQAQ requested review from a team, facaiy and seanpmorgan as code owners September 30, 2019 16:31
seanpmorgan
seanpmorgan requested changes Oct 2, 2019
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM thanks for the clean-up. Small request on updating the README

seanpmorgan
seanpmorgan approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Tzu-Wei!

@seanpmorgan seanpmorgan merged commit 9e90311 into tensorflow:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@facaiy facaiy Awaiting requested review from facaiy

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WindQAQ @seanpmorgan @googlebot