Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Document concurrency semantics for resource variables #112

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Document concurrency semantics for resource variables #112

merged 2 commits into from
Jun 10, 2019

Conversation

@sanjoy
Copy link
Contributor

@sanjoy sanjoy commented Jun 10, 2019

No implementation change is needed, this is the behavior TensorFlow currently implements.

@sanjoy
Copy link
Contributor Author

sanjoy commented Jun 10, 2019

@alextp PTAL.

@ewilderj
Copy link
Contributor

ewilderj commented Jun 10, 2019

To clarify, are we publishing this purely informationally?

@sanjoy
Copy link
Contributor Author

sanjoy commented Jun 10, 2019

To clarify, are we publishing this purely informationally?

Not sure what you mean by "informationally", but this RFC does not propose any implementation changes, but only documents what TensorFlow does today already.

@ewilderj
Copy link
Contributor

ewilderj commented Jun 10, 2019

Not sure what you mean by "informationally", but this RFC does not propose any implementation changes, but only documents what TensorFlow does today already.

By informationally, I mean please confirm we are publishing it for documentation reasons, rather than inviting any comment and review.

@sanjoy
Copy link
Contributor Author

sanjoy commented Jun 10, 2019

By informationally, I mean please confirm we are publishing it for documentation reasons, rather than inviting any comment and review.

Yes, this is only documenting behavior already part of TensorFlow. If there are comments or suggestions (beyond typographical errors) they should be addressed as separate PRs that fix the implementation and the documentation.

@ewilderj
Copy link
Contributor

ewilderj commented Jun 10, 2019

Thanks @sanjoy! I'll wait for an LGTM from @alextp and merge.

alextp
alextp approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@alextp alextp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sanjoy!

@ewilderj ewilderj merged commit fb09c1a into tensorflow:master Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goldiegadde goldiegadde Awaiting requested review from goldiegadde

@martinwicke martinwicke Awaiting requested review from martinwicke

2 more reviewers

@alextp alextp alextp approved these changes

@ewilderj ewilderj ewilderj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sanjoy @ewilderj @alextp @googlebot