Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Conversation

@bhack
Copy link
Contributor

@bhack bhack commented Apr 2, 2021

Fixes #280

@adriangb
Copy link
Contributor

adriangb commented Apr 2, 2021

I tested this in tensorflow/tensorflow#48125 (comment), it didn't seem to tag a team. If tagging won't work, how else can we use this information to flag the team for reviews? Thanks

@bhack
Copy link
Contributor Author

bhack commented Apr 2, 2021

You don't see the link generated cause the link target the same team page. My question is: are they notified? Generally a reviewer is a TF member so the team could be mentioned by the reveiwer.

@adriangb
Copy link
Contributor

adriangb commented Apr 2, 2021

My question is: are they notified?

I agree, this is the important part. If they are notified but no link is generated that is fine, as long as it is documented (I would suggest in this PR). But I think someone should check if that is the case, eg. ping someone manually and see if they got a notification for tensorflow/tensorflow#48125 (comment).

@adriangb
Copy link
Contributor

adriangb commented Apr 2, 2021

I'm commenting here to avoid polluting the conversation in tensorflow/tensorflow#48125.

Interestingly, in your comment I can see that it is a link, but it is greyed out and indeed leads me to a 404. In my comment, it is not even a link. At least this is some confirmation that it works, even if it may require a TF member to make the comment.

image

@bhack
Copy link
Contributor Author

bhack commented Apr 2, 2021

I don't think that they are mentionable by non members. I think it is a Github feature to protect unwanted potential group notification.
So I've added a reminder.

@theadactyl
Copy link
Contributor

cc @ematejska

@ematejska ematejska merged commit 410c44d into tensorflow:master Apr 2, 2021
@bhack bhack deleted the patch-2 branch April 2, 2021 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken link for "TF API Owners"

4 participants