Some fixes for tf.Example notebook. #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put more emphasis on `tf.data`. Use `tf.symbol` more, (these are auto-linked to api pages in the site.) Drop base64 Add note about feature_description set privete_outputs Use reduced size images (ipython inlines them at full res size even if they're only shown with a limited size.)
Member
Author
|
Hi Derek, Jiri We're hoping to publish this tutorial on |
jsimsa
suggested changes
Nov 12, 2018
Contributor
jsimsa
left a comment
jsimsa
left a comment
There was a problem hiding this comment.
@MarkDaoust thank you for the improvements, left some comments for you
Member
Author
|
Thanks for all the feedback @jsimsa. So I think the only outstanding question is: What's the right way to serialize a |
Member
Author
|
All @jsimsa's comments are resolved. Any other comments here? |
jsimsa
reviewed
Nov 14, 2018
Member
Author
|
Is there anything else we need here before a merge? |
brilee
approved these changes
Nov 29, 2018
lamberta
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf.data.tf.symbol, (these are auto-linked to api pages in the site.)Staging:
https://colab.sandbox.google.com/github/MarkDaoust/docs/blob/tf-rec/site/en/tutorials/load_data/tf-records.ipynb