Skip to content

Adds typing information to geometry/transformation/linear_blend_skinning and look_at. #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Adds typing information to geometry/transformation/linear_blend_skinning and look_at. #598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tensorflow_graphics/geometry/transformation/linear_blend_skinning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,14 @@
from tensorflow_graphics.geometry.transformation import rotation_matrix_3d
from tensorflow_graphics.util import export_api
from tensorflow_graphics.util import shape
from tensorflow_graphics.util import type_alias


def blend(points,
skinning_weights,
bone_rotations,
bone_translations,
name="linear_blend_skinning_blend"):
def blend(points: type_alias.TensorLike,
skinning_weights: type_alias.TensorLike,
bone_rotations: type_alias.TensorLike,
bone_translations: type_alias.TensorLike,
name: str = "linear_blend_skinning_blend") -> tf.Tensor:
"""Transforms the points using Linear Blend Skinning.

Note:
Expand Down
5 changes: 4 additions & 1 deletion tensorflow_graphics/geometry/transformation/look_at.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@
from tensorflow_graphics.math import vector
from tensorflow_graphics.util import export_api
from tensorflow_graphics.util import shape
from tensorflow_graphics.util import type_alias


def right_handed(camera_position, look_at, up_vector, name="right_handed"):
def right_handed(camera_position: type_alias.TensorLike,
look_at, up_vector: type_alias.TensorLike,
name: str = "right_handed") -> tf.Tensor:
"""Builds a right handed look at view matrix.

Note:
Expand Down