Add ref and amin argument in dbscale
#1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`amin` will avoid -inf for zero inputs and `ref` will provide more flexibility
awsaf49
changed the title
ref and amin argumentref and amin argument in dbscale
Contributor
Author
|
cc: @terrytangyuan |
Member
terrytangyuan
left a comment
terrytangyuan
left a comment
There was a problem hiding this comment.
Could you add some tests?
Contributor
Author
|
Sure, I am working on it. |
Contributor
Author
|
@terrytangyuan I have added the tests, please approve the workflow. |
Contributor
Author
|
@terrytangyuan there was linting issue with |
Member
|
@awsaf49 @terrytangyuan the windows failure is unrelated - you can ignore it for now. |
Contributor
Author
|
@yongtang In that case, I think we're good to go....... |
yongtang
approved these changes
Mar 14, 2023
zheolong
pushed a commit
to zheolong/io-1
that referenced
this pull request
Jul 24, 2025
* Add `ref` and `amin` argument `amin` will avoid -inf for zero inputs and `ref` will provide more flexibility * Added test for `ref` & `amin` in `dbscale` * Fix for `black` lint --------- Co-authored-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add two parameters
refandaminintfio.audio.dbscale(), similar to librosapower_to_dbfunction.aminwill avoidrefwill provide more flexibility as many user usenp.maxas ref.