-
Notifications
You must be signed in to change notification settings - Fork 306
Patching 0.8.0 release #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r null values (tensorflow#626) * making sure that bigquery reader is returning meaningfull defaults for null values * linter fixes
|
@vlasenkoalexey overall looks good to me. Since tensorflow-io 0.8.0/0.9.0, our way of release is to let Travis CI automatically build all platforms and push "release candidates" to a dropbox location: https://www.dropbox.com/sh/dg0npidir5v1xki/AACor-91kbJh1ScqAdYpxdEca?dl=0 The detail of the release processing is in https://github.com/tensorflow/community/blob/master/sigs/io/RELEASE.md The script to push to dropbox location is in: Line 67 in 98f52b6
then => However, 0.8.0 and 0.9.0 was built from master branch so in after-success.sh: Line 17 in 98f52b6
as you could see only master branch has been covered. Can you also change the above line to cover the branch |
|
Thanks @yongtang, great idea, hope I will be able to use binaries from dropbox and won't have to build macos whls manually. I didn't know about https://github.com/tensorflow/community/blob/master/sigs/io/RELEASE.md |
|
Thanks @vlasenkoalexey. R may need big changes for 2.0 (the binding was build around 1.x before) so it is stalled. We will pick up and update the R once the APIs in tensorflow-io are relatively stable. /cc @terrytangyuan. |
|
@vlasenkoalexey can you also bump the version in: I think both 0.8.1 and 0.9.1 branch may need to be updated. |
yongtang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@vlasenkoalexey The PR looks good, though the Travis CI is failing due to the cache issue. We are using Travis CI to build wheel files on all platforms (Python 2.7/3.5/3.6 for Linux and macOS) so this is an issue for us. To summarize:
The master branch is OK because the cache in Travis CI is generated gradually. But since R0.81 and R0.91 was based on old files, cache on Travis CI may have be dropped. At the moment, the way I can think of to get around this issue, (have done that before), is to:
The above is very clumpy though not sure we have other ways to get around it. Hopefully SIG Build team can help us with the gcs directory (as a bazel cache) soon. Or, we could just try to build everything locally. Linux is not an issue as it uses docker container so we could easily build all versions of wheel files. On mac we may need to build both python 2 and 3. It could be a little annoying though. |
#629