support partially-known and unknown shape specification in decode_json #996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tries to address the isseu in 918 by adding support for partially-known and unknown shape specification in decode_json. In this PR, the shapes are not passed in C++ kernels anymore. Instead, the C++ kernels will always render 1-D output tensor first with a follow-up tf.reshape to fixup the shape later. This PR fixes 918. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
terrytangyuan
approved these changes
Jun 13, 2020
Member
terrytangyuan
left a comment
terrytangyuan
left a comment
There was a problem hiding this comment.
Nice enhancement. Thanks!
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
tensorflow#996) This PR tries to address the isseu in 918 by adding support for partially-known and unknown shape specification in decode_json. In this PR, the shapes are not passed in C++ kernels anymore. Instead, the C++ kernels will always render 1-D output tensor first with a follow-up tf.reshape to fixup the shape later. This PR fixes 918. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
zheolong
pushed a commit
to zheolong/io-1
that referenced
this pull request
Jul 24, 2025
tensorflow#996) This PR tries to address the isseu in 918 by adding support for partially-known and unknown shape specification in decode_json. In this PR, the shapes are not passed in C++ kernels anymore. Instead, the C++ kernels will always render 1-D output tensor first with a follow-up tf.reshape to fixup the shape later. This PR fixes 918. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the isseu in #918 by adding
support for partially-known and unknown shape specification in decode_json.
In this PR, the shapes are not passed in C++ kernels anymore. Instead,
the C++ kernels will always render 1-D output tensor first with a
follow-up tf.reshape to fixup the shape later.
This PR fixes #918.
Signed-off-by: Yong Tang yong.tang.github@outlook.com