Skip to content

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Dec 28, 2017

and gradually tighten the linting rules. for now unused and golint are left out.

some fixes are included in this PR.

using gometaliner instead of just golint because:

  • it covers more cases, e.g. the typo checkings.
  • it also allows for disabling rules w.r.t regex, e.g. when you don't want to enforce all the comment rules enforced by golint

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @jimexist. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Dec 28, 2017

Coverage Status

Coverage increased (+0.2%) to 37.963% when pulling b583ab7 on Jimexist:add-linter into 420f9aa on tensorflow:master.

language: go

go:
- 1.8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fails for some reason...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a TODO and link to appropriate issues?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlewi done adding notes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 37.963% when pulling 5d61049 on Jimexist:add-linter into 420f9aa on tensorflow:master.

@jlewi
Copy link
Contributor

jlewi commented Dec 28, 2017

/ok-to-test

@jlewi
Copy link
Contributor

jlewi commented Dec 28, 2017

nit: Could you update the PR description to explain why you chose gometalinter? As opposed to just using golint?

@jimexist
Copy link
Member Author

@jlewi see PR description that I've updated

@coveralls
Copy link

coveralls commented Dec 29, 2017

Coverage Status

Coverage increased (+0.2%) to 37.963% when pulling e2c44be on Jimexist:add-linter into 420f9aa on tensorflow:master.

@jlewi jlewi merged commit 433b234 into kubeflow:master Dec 29, 2017
@jimexist jimexist deleted the add-linter branch December 30, 2017 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants