Skip to content

Conversation

@karmel
Copy link
Contributor

@karmel karmel commented Mar 14, 2018

These can just be normal unittests. Also, changing the names of the functions, which are making glint complain.

@karmel karmel requested a review from yhliang2018 March 14, 2018 20:53
@karmel karmel requested review from k-w-w and nealwu as code owners March 14, 2018 20:53
@karmel karmel requested review from robieta and removed request for k-w-w and nealwu March 14, 2018 20:53
Copy link
Contributor

@yhliang2018 yhliang2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor nit.

import unittest

import tensorflow as tf
from official.utils.logging import hooks_helper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a blank line after tf import?

@karmel karmel merged commit f56363e into master Mar 14, 2018
@karmel karmel deleted the fix/remove-tf-test-deps branch March 14, 2018 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants