Fix bug where data_async_generation.py would freeze. #4989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data_async_generation.py process would print to stderr, but the main process would redirect it's stderr to a pipe. The main process never read from the pipe, so when the pipe was full, data_async_generation.py would stall on a write to stderr. This change makes data_async_generation.py not write to stdout/stderr.
xueeinstein
added a commit
to xueeinstein/models
that referenced
this pull request
Aug 3, 2018
* 'master' of https://github.com/tensorflow/models: (382 commits) Fix docstrings in data_preprocessing.py. (tensorflow#4976) Fix bug where data_async_generation.py would freeze. (tensorflow#4989) more minor updates update comments and code fixes Point buttons to master branch. minor updates delete debug line Better upload error handling. fix buttons remove link Fix titles, private outputs. minor fixes. Remove whitespace from filename. update gitignore and title update for pr changes Refactor object detection box predictors and fix some issues with model_main. (tensorflow#4965) Added github and colab links (tensorflow#4972) Remove redundant flatten layers. (tensorflow#4964) Delete 4_Neural_Style_Transfer_with_Eager_Execution.py NST Blogpost (tensorflow#4886) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data_async_generation.py process would print to stderr, but the main process would redirect it's stderr to a pipe. The main process never read from the pipe, so when the pipe was full, data_async_generation.py would stall on a write to stderr. This change makes data_async_generation.py not write to stdout/stderr.