Fix MOBILENETV1_CONV_DEFS and EvalSpec string name #5372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feynmanliang
requested review from
derekjchow,
jch1 and
pkulzc
as code owners
Fix name typecheck for EvalSpec
feynmanliang
changed the title
|
This PR already includes all the fixes. Thanks. |
|
Got it, ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both changes were introduced in CL
namemust be string, given: 0 #5371 https://github.com/tensorflow/models/pull/5289/files#diff-76df8ca264a059e8a3003851fe4d7849R644This change is