sarkars/destructor order #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanvi-nervana
approved these changes
Jul 25, 2019
Contributor
kanvi-nervana
left a comment
kanvi-nervana
left a comment
There was a problem hiding this comment.
Minor: add a comment about the need for this change
otherwise LGTM
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
Free all executables before calling ReleaseBackend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bridge holds on to executable in 4 places. When release backend is called, backend releases its shared ptr to executables, and then releases backend. But that doesn't destruct the executable since the bridge is still holding on the the shared pointers.
Hence clearing the maps to make sure when release backend call is made, the backend's shared ptr to executable has
use_count()==1