Shrestha/integrate remove ng assign #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 12, 2019 17:05
… entries in destructor of Encap Op
added 4 commits
July 23, 2019 17:23
…m/tensorflow/ngraph-bridge into shrestha/Integrate_RemoveNGAssign
shresthamalik
commented
Jul 24, 2019
added 4 commits
July 24, 2019 14:13
shresthamalik
requested review from
kanvi-nervana and
sayantan-nervana
and removed request for
kanvi-nervana
kanvi-nervana
approved these changes
Jul 24, 2019
| copy_log_str << " COPY_INP_VAL[0]"; | ||
| } | ||
|
|
||
| // input[1] cannot be from NGraphEncap Op |
Contributor
There was a problem hiding this comment.
May be give more details here
| if (NGraphCatalog::GetCopyToTFFromEncapOutputInfoMap(output_key)) { | ||
| if (var->copy_ng_to_tf()) { | ||
| number_of_copies++; | ||
| copy_log_str << " COPY_TF "; |
Contributor
There was a problem hiding this comment.
maybe change
copy_log_str << " COPY_TF "; -----> copy_log_str << " COPY_TO_TF ";
Co-Authored-By: kanvi-nervana <kanvi.khanna@intel.com>
…m/tensorflow/ngraph-bridge into shrestha/Integrate_RemoveNGAssign
sayantan-nervana
approved these changes
Jul 25, 2019
| OP_REQUIRES_OK(ctx, ctx->resource_manager()->Lookup<NGraphVar>( | ||
| ctx->resource_manager()->default_container(), | ||
| ref_var_name, &var)); | ||
| current_ng_tensor = var->ng_tensor(); |
Contributor
There was a problem hiding this comment.
note to self: important bit here.
gopoka
pushed a commit
that referenced
this pull request
Oct 28, 2019
…sign Shrestha/integrate remove ng assign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.